# Basilisk Milestone delivery 📬

* **Application Document:** [Make cross-chain SDK featuring Basilisk support](https://basilisk.subsquare.io/treasury/proposal/2)
* **Milestone Number:** 1

**Context** 

Milestone delivered upgrades for SDK and featured Basilisk support as well as Basilisk's XYK pallet support. All features were implemented according to plan.


# Basilisk specific delivery

| Number | Deliverable | Link | Notes |
| ------------- | ------------- | ------------- |------------- |
| 0a. | License |[MIT](https://github.com/paraspell/sdk/blob/main/LICENSE)| MIT| 
| 0b.  | Article |[Medium article](https://medium.com/@dudo50/sdk-meant-to-unify-cross-chain-experience-on-polkadot-paraspell-xcm-sdk-ec8a781f4f57)| We will mention Basilisk as supporting chain in Medium article about SDK development| 
| 0c.  | Badge |[Badge in UI](https://github.com/paraspell/ui/commit/b99d4bc29340e7685b956f0e536e27429411d082), [Badge in SDK](https://github.com/paraspell/sdk/commit/405da2b496e5a2947274c049cc8f9433eb423a5e) | Badges for each Repo| 
| 1.  | Implement support for checking asset compatibility on Basilisk through `asset pallet` |[Asset pallet commit](https://github.com/paraspell/sdk/commit/2747e85a0683fa652b8799365ac9cefd25251512)|Check which tokens are supported and allow user to use them through SDK | 
| 2.a | Implement support for Basilisk's XYK pallet|[Basilisk XYK 1/2 - Function pattern style](https://github.com/paraspell/sdk/commit/c3b744bf5e7fec065c69be74db597a1020307c8d), [Basilisk XYK 2/2 - Builder pattern](https://github.com/paraspell/sdk/commit/d22d3fec7497dc938e322a8eaf487ade014b8723)| Add ability to exchange asset for another, create pool and more through Basilisk `XYK Pallet` | 
| 2.b  | Wiki guide Basilisk's XYK pallet |[XYK Wiki](https://paraspell.github.io/docs/sdk/XYK.html)| Add comprehensive guide on usage of XYK Pallet via SDK| 
| 2.c  | UI Example on Basilisk's XYK pallet |[XYK UI](https://github.com/paraspell/ui/commit/ce9dac236e8255dcb482e595b633f6228baf396e)| Create simple UI example that allows for quick demonstration of XYK Pallet and users are able to see how it can be implemented into dApp| 


# General delivery

| Number | Deliverable | Link | Notes |
| ------------- | ------------- | ------------- |------------- |
| 0a. | License |[MIT](https://github.com/paraspell/sdk/blob/main/LICENSE)| MIT| 
| 0c.  | Testing guide |[Testing guide](https://github.com/paraspell/xcm-sdk/tree/main#-development)| Core functionality & user guide will be covered in repository documentation as well as SDK UNIT tests for core functionality| 
| 1. | Add SDK ability to transfer different token types |[Asset pallet commit](https://github.com/paraspell/sdk/commit/2747e85a0683fa652b8799365ac9cefd25251512)| Nodes, that support different token type transfers will have ability to customize this | 
| 2 | Make SDK easier to use|[Merging scenarios commit](https://github.com/paraspell/sdk/commit/e7921bc68db74e6c2e2d3fc23166d145f063b3e3)| Merge Parachain to Parachain & Parachain to Relay chain scenarios in SDK into one scenario that will be able to adapt based on details provided (if destination node id not provided, then assume transfer is for relay chain, also if token is compatible with relay chain), this will replace need for calling two functions for each scenario with only one function covering both scenarios eg. `send()` instead `paratopara()` & `paratorelay()` | 
| 3.a  | Add support for nodes without xTokens pallet I |[Commit adding compatible polkadotXCM nodes](https://github.com/paraspell/sdk/commit/9fc45356f7976066b0ee9ee5c44e1df4be35ed6a)| Implemented  support for transfer scenario Parachain to Relay chain for nodes that do not have xTokens pallet but have polkadotXCM or other XCM pallet. SDK is be able to determine which pallet to use on which Parachain automatically. These nodes can transfer native Relay chain tokens upwards to Relay chain.| 
| 3.b  | Add support for nodes without xTokens pallet II |[Commit adding compatible polkadotXCM nodes](https://github.com/paraspell/sdk/commit/9fc45356f7976066b0ee9ee5c44e1df4be35ed6a)| Implemented  support for transfer scenario Parachain to Parachain for nodes that do not have xTokens pallet but have polkadotXCM or other XCM pallet. SDK is be able to determine which pallet to use on which Parachain automatically. These nodes can transfer their native tokens into another Parachains which have HRMP channel with them.| 
| 4 | Add support for checking data that does not change |[Implementing constants that do not change like node id and asset decimals](https://github.com/paraspell/sdk/commit/aea02541f7168d7a7f566b7311fcf70f6a977115)| There are things that do not change, such as base token configuration (Polkadot, DOT token, 10 decimals), (Basilisk, BSX, 12 decimals), (Astar, ASTR, 18 decimals) This can be imported from @polkadot/network to have better support for different transfer scenarios. | 
| 5 | Rewrite SDK to builder pattern |[Builder pattern commit](https://github.com/paraspell/sdk/commit/74fba22522449a75ecdc82a394ff2336d9c1ec05), [Builder pattern usage guide](https://github.com/paraspell/xcm-sdk#currently-implemented-pallets)| Best thing we can do to support multiple pallets and make it simplier for developers would be a Builder pattern functionality would look like: import { Builder } as `@paraspell/sdk` and then building of call would be something in sence: `const call = Builder(api).from(‘bsx’).to(‘ksm’).teleportTokens(‘KSM’).addr('destinationAddr').sum(currencySum).asV3().build()`. | 
| 3.  | Make a map of compatible <chain, pallet> |[xcmPallet map feature](https://github.com/paraspell/xcm-sdk/commit/8faa6ffb4e3e8640dd4a59008d2d456a1be0cefd), [usage guide for testing](https://github.com/paraspell/xcm-sdk/commit/c6f4bfa810444eab9f101dcdc2062ff7d7ca86b0)| Before each SDK release there should be a script that connects to the compatible nodes, checks all relevant available pallets `xTokens`, `polkadotXCM`, `asset pallets`, `HRMP pallets`) and saves them to the map.| 
| 7 | Use turborepo |[Monorepo branch](https://github.com/paraspell/xcm-sdk/tree/beta-monorepo)| Remake package into monorepo for easier importing and cleaner use. (Note this is created with future expand plans) | 
| 8 | Add Wiki guide |[Wiki guide](https://paraspell.github.io/docs/)| We will provide useful Wiki guide that will explain data that is used by different transfer scenarios. We will also explain how to add new nodes that will be compatible.| 

**Additional Information**
Every aspect of project, that was defined in proposal, was implemented according to it. There were no changes required during development. Users are now able to use standard Paraspell XCM features as well as Basilisk XYK Pallet through SDK. Happy hacking!


proposalId

ParaSpell XCM-SDK featuring Basilisk support - Delivery Milestone 1

WRONG SUM ENTERED.
Please scrape this proposal.